Add process_request_options/1 to HTTPoison.Base #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this seem like something you'd be willing to merge in? Anything else I can do here? |
|
I'm keen to accept this PR as it seems to be more common than what I thought it was (#74). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found myself wanting to add the
:proxyoption to all requests if a specific env var was present in a deployment environment. I was able to do so by overridingrequestonHTTPoison.Base, but I think having an overridableprocess_request_optionsis a better approach. This PR adds it.The best testing approach I could come up with was adding the
:timeoutoption in the override. I hope this makes sense.