Skip to content

BLD: Pin requirements. #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danielballan
Copy link
Contributor

@danielballan danielballan commented Aug 1, 2018

Pinned to versions in my local dev environment that work, just to start. If the
tests pass we can upgrade from there using dependency monitoring.

Closes #195

@Mr0grog
Copy link
Member

Mr0grog commented Aug 1, 2018

Well, that build failed the tests pretty hard. IIRC, when @ftsalamp did #185, I had to upgrade to Tornado 5 (and indeed, my local virtualenv for this app is running 5.0.2). I thought the production service was also updated, but I’m looking at it now and it’s not, so I’m worried about what failures are failing worse than they should or what edge cases we have luckily not tripped over.

FWIW, the output of pip freeze in my local (where tests are passing):

alabaster==0.7.10
appnope==0.1.0
asn1crypto==0.24.0
attrs==18.1.0
Babel==2.5.3
backcall==0.1.0
beautifulsoup4==4.6.0
boto3==1.7.48
botocore==1.10.48
certifi==2018.4.16
cffi==1.11.5
chardet==3.0.4
coverage==4.5.1
cryptography==2.2.2
cycler==0.10.0
decorator==4.3.0
diff-match-patch-python==1.0.2
docopt==0.6.2
doctr==1.7.3
docutils==0.14
flake8==3.5.0
html-tree-diff==0.1.2
html5lib==1.0.1
htmldiffer==0.25.1
idna==2.6
imagesize==1.0.0
ipython==6.3.1
ipython-genutils==0.2.0
jedi==0.12.0
Jinja2==2.10
jmespath==0.9.3
kiwisolver==1.0.1
lxml==4.2.1
MarkupSafe==1.0
matplotlib==2.2.2
mccabe==0.6.1
more-itertools==4.1.0
multidict==4.3.1
numpy==1.14.3
numpydoc==0.8.0
packaging==17.1
pandas==0.22.0
parso==0.2.0
pexpect==4.5.0
pickleshare==0.7.4
pluggy==0.6.0
prompt-toolkit==1.0.15
ptyprocess==0.5.2
py==1.5.3
pycodestyle==2.3.1
pycparser==2.18
pyflakes==1.6.0
Pygments==2.2.0
pyparsing==2.2.0
pytest==3.5.1
python-dateutil==2.7.2
pytz==2018.4
PyYAML==3.12
requests==2.18.4
requests-mock==1.4.0
s3transfer==0.1.13
simplegeneric==0.8.1
six==1.11.0
snowballstemmer==1.2.1
Sphinx==1.7.4
sphinx-rtd-theme==0.3.1
sphinxcontrib-websupport==1.0.1
toolz==0.9.0
tornado==5.0.2
tqdm==4.23.3
traitlets==4.3.2
tzlocal==1.5.1
urllib3==1.22
vcrpy==1.11.1
wcwidth==0.1.7
-e git+git@github.com:edgi-govdata-archiving/web-monitoring-processing.git@85f4f3d098749928ca571f2e4ec3473866a9e4ea#egg=web_monitoring
webencodings==0.5.1
wrapt==1.10.11
yarl==1.2.4

And in production:

asn1crypto==0.22.0
beautifulsoup4==4.6.0
certifi==2017.7.27.1
cffi==1.10.0
chardet==3.0.4
conda==4.3.30
cryptography==2.0.3
diff-match-patch-python==1.0.2
docopt==0.6.2
html-tree-diff==0.1.2
html5lib==0.999999999
htmldiffer==0.25.1
idna==2.6
lxml==4.1.1
numpy==1.13.3
pandas==0.21.0
pycosat==0.6.2
pycparser==2.18
pyOpenSSL==17.2.0
PySocks==1.6.7
python-dateutil==2.6.1
pytz==2017.3
requests==2.18.4
ruamel-yaml==0.11.14
six==1.10.0
toolz==0.8.2
tornado==4.5.2
tqdm==4.19.4
tzlocal==1.4
urllib3==1.22
web-monitoring==0+untagged.428.g811f701
webencodings==0.5.1

@Mr0grog
Copy link
Member

Mr0grog commented Aug 1, 2018

This PR should also update dev-requirements.txt, shouldn’t it?

@Mr0grog
Copy link
Member

Mr0grog commented Aug 1, 2018

…and lo, the version numbers did instantly demonstrate their value!

@danielballan danielballan force-pushed the pin-requirements branch 9 times, most recently from 283d30d to 14189b9 Compare August 2, 2018 21:10
And alphabetically sort them while we are at it.
Copy link
Member

@Mr0grog Mr0grog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! \o/

@danielballan danielballan merged commit dcd8330 into edgi-govdata-archiving:master Aug 2, 2018
@danielballan danielballan deleted the pin-requirements branch August 2, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants