Upgrade Ruby to v3.2.4 #1110
Merged
Upgrade Ruby to v3.2.4 #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves some security vulnerabilities. Technically we should probably upgrade to v3.2.4 (same security patches, but for the 3.2 release line), but there's no obvious reason not to just move up to the 3.3 release line and no breaking changes.
|
CircleCI has not yet released an image for this version of Ruby. Tests pass locally, so I don’t expect to see any failures once CircleCI updates, but I’ll still wait for CI before merging just in case. |
|
Welp, turns out Ruby 3.3.x requires a newer version of Rubocop, which wants us to make a lot of other code changes. Due to the maintenance status here, I’m switching to Ruby 3.2.4, which has the same security fixes. |
Upgrading to 3.3.x required upgrading RuboCop, which demanded a whole laundry list of other changes. Given the maintenance status here, it's better to just stay on the Ruby 3.2.x line.
Mr0grog
added a commit
that referenced
this pull request
Apr 24, 2024
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some security vulnerabilities (see https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-3-1-released/). Technically we should probably upgrade to v3.2.4 (same security patches, but for the 3.2 release line), but there's no obvious reason not to just move up to the 3.3 release line and no breaking changes.