Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabled notice to AnalyzeChangeJob #1091

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/jobs/analyze_change_job.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# NOTE: THIS JOB IS NOT IN ACTIVE USE.
# The use cases it served were better solved by the task-sheets project
# (https://github.com/edgi-govdata-archiving/web-monitoring-task-sheets).
# That said, the outputs there were never integrated into the database here in
# an automated way, which this job did.
#
# The job code here is preserved in case we need to turn it back on.
class AnalyzeChangeJob < ApplicationJob
queue_as :analysis

Expand Down
2 changes: 1 addition & 1 deletion app/jobs/import_versions_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def perform(import)
Rails.logger.error "Import #{import.id}: Cannot queue AnalyzeChangeJob -- #{error.message}"
end
else
Rails.logger.warn "Import #{import.id}: Auto-analysis requirements are not configured; AnalyzeChangeJobs were not scheduled for imported versions."
Rails.logger.warn "Import #{import.id}: Auto-analysis is not configured; AnalyzeChangeJobs were not scheduled for imported versions."
end
end

Expand Down
2 changes: 1 addition & 1 deletion test/jobs/import_versions_job_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def teardown
"[import=#{import.id}][row=0] Found Page #{page.uuid}",
"[import=#{import.id}][row=0] Replaced Version #{versions(:page1_v5).uuid}",
"[import=#{import.id}] Finished Import #{import.id}",
"Import #{import.id}: Auto-analysis requirements are not configured; AnalyzeChangeJobs were not scheduled for imported versions."
"Import #{import.id}: Auto-analysis is not configured; AnalyzeChangeJobs were not scheduled for imported versions."
], Rails.logger.logs, 'Logs are not as expected.')
end

Expand Down