This repository has been archived by the owner on May 26, 2023. It is now read-only.
reading list: Set device by flag instead of arg #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkbhanda
reviewed
Jun 17, 2020
Usually Args are reserved for commonad object ID (in our case reading ID) That is why now the device (name) is currently set by flag --device Set more appropriate helpers messages Address partially: edgexfoundry#213 Signed-off-by: Diana Atanasova <dianaa@vmware.com>
mkbhanda
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually Args are reserved for commands object ID (in our case reading ID)
That is why now the device (name) is currently set by flag --device
Address partially: #213
Signed-off-by: Diana Atanasova dianaa@vmware.com