This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
refactor: Update configuration for change to common ServiceInfo struct #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #164 BREAKING CHANGE: Service configuration has changed Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/master/.github/Contributing.md
What is the current behavior?
Using DS specific SeviceInfo Struct with additional settings
Issue Number: #164
What is the new behavior?
Now using common SeviceInfo Struct
Moved non-common settings under
[Device]sectionDoes this PR introduce a breaking change?
BREAKING CHANGE: Service configuration has changed
New Imports
Specific Instructions
Other information