refactor: Updated profiles to use service keys for Client names #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes edgexfoundry#212 BREAKING CHANGE: Clients configuration has changed Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
service-key
branch
from
0311b7b to
762a43c
Compare
jim-wang-yutsung
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on edgexfoundry/app-functions-sdk-go#747 to be merged first.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Clients configuration in profiles use old names for services.
Issue Number: #212
What is the new behavior?
Clients configuration in profiles now use the standard service keys for the names for the services.
Does this PR introduce a breaking change?
BREAKING CHANGE: Clients configuration has changed
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information