Potential fix for code scanning alert no. 1: Uncontrolled command line#22
Draft
ShankarWarang wants to merge 1 commit intomilestone-2from
Draft
Potential fix for code scanning alert no. 1: Uncontrolled command line#22ShankarWarang wants to merge 1 commit intomilestone-2from
ShankarWarang wants to merge 1 commit intomilestone-2from
Conversation
Code that passes untrusted user input directly to child_process.exec or similar APIs that execute shell commands allows the user to execute malicious code. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/edgeware-network/agent-dot/security/code-scanning/1
General approach: avoid spawning a shell with a concatenated string. Instead, invoke the package manager executable directly using
execFileSync(orspawnSync) and pass command and arguments as an array of strings. This prevents shell metacharacters in user input from being interpreted by a shell.Best concrete fix here:
execSynccall withexecFileSyncfromchild_process.install,run, etc.).commandby whitespace, as that would break quoted arguments. Instead, we can:process.argv.slice(2)in an array, andsubcommandandargsfrom that array (no need to ever create thecommandstring).execSyncfor the version checks (bun --version,pnpm --version), as those do not involve untrusted data.Concretely, in
scripts/run-with-pm.cjs:const pm = detectPackageManager();.const command = process.argv.slice(2).join(" ");withconst argv = process.argv.slice(2);.argv.length.subcommand = argv[0]andargs = argv.slice(1)and call:execFileSyncalongsideexecSync.This change keeps the semantics of “run the chosen package manager with the supplied arguments” without exposing a shell injection surface.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.