Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/user metrics #1

Merged
merged 13 commits into from
Jul 14, 2022
Merged

Feature/user metrics #1

merged 13 commits into from
Jul 14, 2022

Conversation

willgarrett64
Copy link
Contributor

@willgarrett64 willgarrett64 commented Jul 13, 2022 •
edited
Loading

No description provided.

@willgarrett64 willgarrett64 self-assigned this Jul 13, 2022
@willgarrett64 willgarrett64 marked this pull request as draft July 13, 2022 17:02
@willgarrett64 willgarrett64 marked this pull request as ready for review July 14, 2022 09:00
adamkdean
adamkdean requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@adamkdean adamkdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting changes required, but also the deployment changes aren't present in this PR. They will be needed also.

src/network-bot/index.ts Outdated Show resolved Hide resolved
src/network-bot/metrics/index.ts Outdated Show resolved Hide resolved
src/network-bot/metrics/index.ts Outdated Show resolved Hide resolved
adamkdean
adamkdean approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@adamkdean adamkdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willgarrett64 willgarrett64 merged commit d082760 into master Jul 14, 2022
@willgarrett64 willgarrett64 deleted the feature/user-metrics branch July 14, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkdean adamkdean adamkdean approved these changes

@annybs annybs Awaiting requested review from annybs

Assignees

@willgarrett64 willgarrett64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willgarrett64 @adamkdean