Skip to content

Fix selection hyperparameter #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

Fix selection hyperparameter #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d53bdc
Bugfix impersistent hypparam values
KtrauM Dec 3, 2023
7dc059b
Fix selection menu overflowing behind modal footer
KtrauM Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Hyperparameters/HyperparameterView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,13 @@ export const HyperparameterView = ({
</Col>
);
} else if (h.parameter_type === 'selection') {
console.log(h.value);
return (
<Col className="col-md-6 col-12 pl-0">
<SelectionHyperparameter
{...h}
id={'input_' + h.parameter_name}
handleChange={handleHyperparameterChange}
value={h.value}
value={{ value: h.value, label: h.value }}
/>
</Col>
);
Expand Down
10 changes: 8 additions & 2 deletions src/components/Hyperparameters/SelectionHyperparameter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,26 @@ import makeAnimated from 'react-select/animated';
import Hyperparameter from './Hyperparameter';

const SelectionHyperparameter = (props) => {
console.log(props.value);
return (
<Hyperparameter {...props}>
<Select
styles={{
control: (provided) => ({
...provided,
textAlign: 'center',
}),
}}
options={props.options.map((e) => {
return { value: e, label: e };
})}
menuPosition="fixed"
isMulti={props.multi_select}
value={props.value}
defaultValue={props.value}
onChange={(e) => {
props.handleChange({
parameter_name: props.parameter_name,
state: e,
state: e.value,
});
}}
components={makeAnimated()}
Expand Down
4 changes: 2 additions & 2 deletions src/components/TrainingWizard/Steps/Select_Hyperparameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ const Wizard_Hyperparameters = ({

const [classififier_index, set_classifier_index] = useState(0);

const handleHyperparameterChange = ({ parameter_name, value }) => {
const handleHyperparameterChange = ({ parameter_name, state }) => {
const newClassifier = [...classifier];
const idx = newClassifier[classififier_index].parameters.findIndex(
(elm) => elm.parameter_name === parameter_name
);
newClassifier[classififier_index].parameters[idx].value = value;
newClassifier[classififier_index].parameters[idx].value = state;
setClassifier(newClassifier);
setSelectedClassifier(newClassifier[classififier_index]);
};
Expand Down