-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
breaking-changeInvolves breaking changesInvolves breaking changesenhancementNew feature or requestNew feature or request
Milestone
Description
Description
We broke current testcases in version 2.0.0 and released 2.0.2 fixing it (59beaca, 0065913), but the fix looks hacky one.
Let's improve it in the next major version and make some examples in README how 3rd party developers should properly write tests using this package.
The problem which lead to the behaviour changed was $pendingClient = clone $this->clients[$name];
. Meaning it clones a new client every time TmsApi::client('default')
is called. This solved the problem in v1 where timeouts and middleware were global for all further requests using that client, but made a testing with laravel HTTP client (preventStrays
, fake
) much harder in 3rd party code.
Metadata
Metadata
Assignees
Labels
breaking-changeInvolves breaking changesInvolves breaking changesenhancementNew feature or requestNew feature or request