User repos caching improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RepoFormatter replaced with Repo class. - Deleted delay after type in main gh alfred trigger. - Local Storage class extended with functionality of saving and reading raw string instead of always serializing to JSON.
|
P.S. It should be compatible with the previous version since the cache will be considered outdated due to the lack of a "cache-timestamp" file. |
edgarjs
approved these changes
Jan 16, 2020
|
Hey @edgarjs, Thanks for the review. I made some updates, please check :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again, @edgarjs!
Added improvements mentioned in the previous PR:
@nameand@link. This improved performance a lot.gh <term>command now, I disabled Alfred's "delay after type" functionality.Possible improvements:
github/api.rbbecomes a little bit too big and not just an API connector anymore. Potentially, extracting all logic apart from actual API requests (along with all these@hoststuff) would help for code quality.Please review the changes carefully. Ruby is so magical and explicit, I easily could mess up something.
Thank you.