Repository navigation
feat(image): accept a bare image manifest as manifest.json - #64
Merged
Merged
Conversation
tycho
force-pushed
the
steven/feat/manifest-json-image-manifest
branch
from
October 5, 2026 18:03
0d08b22 to
1e56a9e
Compare
tycho
added this pull request to stack #66
October 5, 2026 18:03
Without an index.json, `load_manifest` understood only the manifest.json that `docker save` writes: an array with one entry per tagged image, listing layers as relative blob paths. A layout assembled from a registry's responses instead -- the image manifest saved as manifest.json, its blobs under `blobs/sha256/` -- failed with "invalid type: map, expected a sequence", even though the manifest is in the standard OCI form. Dispatch on the JSON's shape: an array is still read as a Docker save manifest, unchanged, and an object is read as a single image manifest into the existing `OciManifest` type. That covers OCI image manifests and Docker's registry schema 2 manifests alike, since both list layers as descriptors, and a layer without a `mediaType` falls back to magic-byte detection as elsewhere. Any other object, such as an image index saved under that name, is rejected with an error saying an image manifest was expected. Suggested-by: MrNavaStar <43613843+MrNavaStar@users.noreply.github.com> Signed-off-by: Steven Noonan <steven@edera.dev>
tycho
force-pushed
the
steven/feat/manifest-json-image-manifest
branch
from
October 5, 2026 18:06
1e56a9e to
74e9503
Compare
tycho
marked this pull request as ready for review
October 5, 2026 18:06
azenla
approved these changes
Oct 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an
index.json, ocirender only understood themanifest.jsonthatdocker savewrites. A layout assembled from a registry's responses instead, with the image manifest itself saved asmanifest.json, failed to load.manifest.jsonis now read by shape: an array is still a Docker save manifest, and an object is a single OCI or Docker schema 2 image manifest. This is additive; existing layouts load exactly as before. Covered by parsing tests and an e2e fixture layout verified against umoci.Supersedes #53.