sanitize user_login

edent · Sep 11, 2023 · 5fbf931 · 5fbf931
1 parent 8a74aa5
commit 5fbf931
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -1,5 +1,5 @@
 # ActivityPub #
-**Contributors:** [automattic](https://profiles.wordpress.org/automattic/), [pfefferle](https://profiles.wordpress.org/pfefferle/), [mediaformat](https://profiles.wordpress.org/mediaformat/), [mattwiebe](https://profiles.wordpress.org/mattwiebe/), [akirk](https://profiles.wordpress.org/akirk/), [jeherve](https://profiles.wordpress.org/jeherve/), [nuriapena](https://profiles.wordpress.org/nuriapena/)  
+**Contributors:** [automattic](https://profiles.wordpress.org/automattic/), [pfefferle](https://profiles.wordpress.org/pfefferle/), [mediaformat](https://profiles.wordpress.org/mediaformat/), [mattwiebe](https://profiles.wordpress.org/mattwiebe/), [akirk](https://profiles.wordpress.org/akirk/), [jeherve](https://profiles.wordpress.org/jeherve/), [nuriapena](https://profiles.wordpress.org/nuriapena/), [cavalierlife](https://profiles.wordpress.org/cavalierlife/)  
 **Tags:** OStatus, fediverse, activitypub, activitystream  
 **Requires at least:** 4.7  
 **Tested up to:** 6.3  

diff --git a/includes/class-signature.php b/includes/class-signature.php
@@ -121,17 +121,19 @@ protected static function generate_key_pair_for( $user_id ) {
 	}
 
 	/**
-	 * Undocumented function
+	 * Return the option key for a given user.
 	 *
-	 * @param [type] $user_id
-	 * @return void
+	 * @param int $user_id The WordPress User ID.
+	 *
+	 * @return string The option key.
 	 */
 	protected static function get_signature_options_key_for( $user_id ) {
 		$id = $user_id;
 
 		if ( $user_id > 0 ) {
 			$user = \get_userdata( $user_id );
-			$id = $user->user_login;
+			// sanatize username because it could include spaces and special chars
+			$id = sanitize_title( $user->user_login );
 		}
 
 		return 'activitypub_keypair_for_' . $id;

diff --git a/readme.txt b/readme.txt
@@ -1,5 +1,5 @@
 === ActivityPub ===
-Contributors: automattic, pfefferle, mediaformat, mattwiebe, akirk, jeherve, nuriapena
+Contributors: automattic, pfefferle, mediaformat, mattwiebe, akirk, jeherve, nuriapena, cavalierlife
 Tags: OStatus, fediverse, activitypub, activitystream
 Requires at least: 4.7
 Tested up to: 6.3