This repository was archived by the owner on Oct 15, 2025. It is now read-only.
Feature/normalization of beattable 253 #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magwas
suggested changes
Mar 31, 2019
Member
magwas
left a comment
magwas
left a comment
There was a problem hiding this comment.
sonar is right on all two counts
Contributor
Author
|
Thanks fixed. |
magwas
approved these changes
Mar 31, 2019
Member
|
testcasecount=6 |
szirbucz
suggested changes
Mar 31, 2019
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I would use compareBeats instead of re-implementing its functionality.
Member
There was a problem hiding this comment.
Valentin grabbed it before I could comment here
magwas
pushed a commit
that referenced
this pull request
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.