Skip to content

Improvement: Make ClipboardAsset a dependant of BootstrapAsset instead of extending it #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvement: Make ClipboardAsset a dependant of BootstrapAsset instead of extending it #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc81c37
make ClipboardAsset a dependant of BoostrapAsset insted of extending …
iyiolapeter Aug 22, 2019
9b6ef3b
register asset on view
iyiolapeter Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Clipboard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class Clipboard extends InputWidget
*/
public function run()
{
ClipboardAsset::register($this->getView());
return self::asHtml(
$this->getView(),
$this->type,
Expand Down Expand Up @@ -136,7 +137,8 @@ private static function asHtml(View $view, $type, $action, $name = null, $value
['class' => 'input-group']),
['class' => 'clearfix']
);


ClipboardAsset::register($view);
$view->registerJs("new ClipboardJS('.btn-".$id."')");

return $content;
Expand Down
7 changes: 5 additions & 2 deletions src/ClipboardAsset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@

namespace Eddmash\Clipboard;

use yii\bootstrap\BootstrapAsset;
use yii\web\AssetBundle;

/**
* Asset bundle for Clipboard js.
*/
class ClipboardAsset extends BootstrapAsset
class ClipboardAsset extends AssetBundle
{
public $sourcePath = '@bower/clipboard/dist';
public $js = [
'clipboard.min.js',
];
public $depends = [
'yii\bootstrap\BootstrapAsset'
];
}