Pass Mooneye Test Suite

[eddmann]

Description

Run and pass the comprehensive Mooneye Test Suite to validate emulator accuracy and identify any hardware behavior discrepancies.

Tasks

• Set up Mooneye Test Suite integration
• Create automated test runner
• Document current pass/fail status
• Fix failing CPU instruction tests
• Fix failing timer tests
• Fix failing PPU tests
• Fix failing memory tests
• Fix failing interrupt tests
• Achieve full test suite pass rate

Test Categories

• Acceptance tests
• Emulator-only tests
• Manual tests
• MBC tests
• Timer tests
• PPU tests
• Serial tests
• Interrupt tests

Acceptance Criteria

• All applicable Mooneye tests pass
• Document any tests that are skipped and why
• Create CI integration to prevent regressions

References

• Mooneye Test Suite
• Test ROM documentation

[eddmann]

Current Implementation Status: ✅ Infrastructure Complete, 🔄 Tests Disabled

What's Already Implemented

The test infrastructure is fully implemented and working:

✅ Test ROM Runner (tests/Integration/TestRomRunner.php)

• Automated test ROM execution
• Pass/fail detection for Blargg and Mooneye tests
• Timeout handling (10-60 seconds)
• Serial output capture
• PHPUnit integration

✅ Blargg CPU Tests: 11/11 PASSING (100%)
All CPU instruction tests pass:

• cpu_instrs (all instructions)
• instr_timing (timing accuracy)
• Tests located: third_party/roms/cpu_instrs/

Mooneye Test Suite Status

⚠️ Tests Present But DISABLED: tests/Integration/MooneyeTestRomsTest.php.disabled

Current Pass Rate: 10/39 (25.6%)

The Mooneye test file exists with 39 acceptance tests defined, but has been disabled (file renamed with .disabled extension).

What Needs to Be Done

Immediate Actions:

1. Re-enable tests: Rename MooneyeTestRomsTest.php.disabled → MooneyeTestRomsTest.php
2. Run test suite: ./vendor/bin/phpunit tests/Integration/MooneyeTestRomsTest.php
3. Document failures: Identify which 29 tests are failing and why
4. Fix failing tests (likely timing-related)

Test Categories to Fix:

• Timer tests (timing accuracy)
• PPU tests (rendering edge cases)
• Memory tests (access timing)
• Interrupt tests (timing and priority)

How to Run Tests

# Enable Mooneye tests
mv tests/Integration/MooneyeTestRomsTest.php.disabled tests/Integration/MooneyeTestRomsTest.php

# Run all integration tests
make test-roms

# Run Mooneye tests specifically
./vendor/bin/phpunit tests/Integration/MooneyeTestRomsTest.php

# Run specific test
./vendor/bin/phpunit --filter=testBits_mem_oam tests/Integration/MooneyeTestRomsTest.php

Expected Test Results

Based on the test file, these 39 tests should pass:

• bits/mem_oam
• bits/reg_f
• instr/daa
• add_sp_e_timing
• call_timing
• Plus 34 more timing/instruction tests

Integration with CI/CD

Once tests are stable:

• Add Mooneye tests to CI pipeline
• Set up automated regression testing
• Create test failure alerts

References

• Test runner: tests/Integration/TestRomRunner.php
• Disabled test file: tests/Integration/MooneyeTestRomsTest.php.disabled
• Mooneye Test Suite
• Current passing tests: Blargg CPU tests (100%)

Root Cause Analysis Needed

The tests were likely disabled due to timing accuracy issues. PHPBoy uses simplified timing in some areas (noted in STATUS.md):

1. Pixel transfer timing is fixed (should vary)
2. Memory access timing during rendering not enforced
3. Some instruction timing may be approximate

These timing differences likely cause Mooneye test failures.