Bring back noReferences, maybeReferenced#5
Merged
eddelbuettel merged 4 commits intoeddelbuettel:masterfrom Nov 28, 2025
Merged
Conversation
Use the NO_REFERENCES() entry point introduced in R-3.1.0.
Owner
|
Oh gosh I rushed and wrote too soon. I see now (and removed the erroneous earlier post). You did not use Can you please add a ChangeLog entry? |
Contributor
Author
|
This had happened to me as well :) I should've provided more context.
|
eddelbuettel
requested changes
Nov 28, 2025
This reverts commit 2b0e78c.
eddelbuettel
approved these changes
Nov 28, 2025
| 2025-11-28 Ivan Krylov <krylov.r00t@gmail.com> | ||
|
|
||
| * inst/include/tidy/internals.h: Reintroduced noReferences, | ||
| maybeReferenced using a different R API function |
Owner
There was a problem hiding this comment.
Thank you! The whitespace are off a little but I can take it from here.
Owner
|
While I have you here, and while I still have your opus magnus blog post in a tab for re-reading (for months now ...) I have of course also been thinking about the R API site and possible automation. Do you think we can / should generate these include files automagically? Shall we open another issue to discuss that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have a strong opinion regarding this, but if you'd like to, you can make these functions use the
NO_REFERENCES()entry point introduced in R-3.1.0.