Edfial 381 env vars for token issuer and audience #13
Conversation
cloudformation/templates/1-main.yml
Outdated
| prod: https://auth0.edanalytics.app' | ||
| AllowedValues: | ||
| - 'https://auth0.internal-dev.edanalytics.app' | ||
| - 'https://auth0.edanalytics.app' |
There was a problem hiding this comment.
If someone runs Runway outside EA, they'll need to use their own token issuer and shouldn't be limited to the EA Auth0 instances.
There was a problem hiding this comment.
How do you want to handle know what to put in there then? The readme will need to be updated stating that when deploying the issuer should be supply their Token Issuer?
There was a problem hiding this comment.
Yeah, you're right that the README needs configuration instructions for the external API. There's not just this param, but they'll need to correctly configure an API client. I'll put together something there.
In here, I mostly want to make sure we're not restricting this parameter to values that only make sense for EA.
Maybe adding a bit to the description might help it make sense without the restricted values? Something like this?
URL of the identity provider that issues access tokens for external API requests. If not set, API access is disabled; the web application continues to function.
There was a problem hiding this comment.
Does the PR also need to update x-parameter-values.md?
There was a problem hiding this comment.
I removed the EA urls. Updated the description. And added the entry to the x-parameter-values.md.
PR adds EXTERNAL_API_TOKEN_ISSUER parameter. Needs to be merged into development, then can deploy this to dev runway.