DS v5 Program Updates #154
Conversation
rlittle08
left a comment
rlittle08
left a comment
There was a problem hiding this comment.
besides adding school_year, i have no requests! appreciate the attention to detail & following practices!
We will, however, need to save this for the next point release (0.6.0), so implementations can add the new raw tables as part of a breaking update
|
|
||
| -- generic | ||
| tenant_code, | ||
| api_year, |
There was a problem hiding this comment.
as you called out in the slite doc, please include school_year in each of the models as a simple rename of api_year
| v:programReference as program_reference, | ||
|
|
||
| -- lists | ||
| v:levels as v_levels, |
There was a problem hiding this comment.
can we name v_program_evaluation_levels?
There was a problem hiding this comment.
looks perfect. lots of nesting here, thanks for being meticulous with handbook + api docs!
|
@jabortell please also add to changelog.md when you have time, but no rush, as we're saving this for 0.6.0 |
|
|
||
| keyed as ( | ||
| select | ||
| tenant_code, |
There was a problem hiding this comment.
@rlittle08 I'm noticing that I selected tenant_code and api_year here, but not in the other staging models, and I don't know why I did that lol. I feel like I only need api_year as school_year, right?
Links:
Testing Instructions:
student_program_evaluationsandstudent_special_education_program_eligiblity_associations.sourcesspecification, whether your testing fromedu_whor from astadium_*project.DEV_RAW.EDFI3_JBORTELL, which contains the new raw tables. If you'd like to pursue this and need help, do reach out and I'll be happy to help.stadium_*project or from the root ofedu_wh. There most likely will not be data in the new models.gen_skey()deduplicate()are including the correct columnsBreaking Changes:
edu_whto specify the new sources, and those raw tables will need to be initialized in Snowflake.