Skip to content

Bugfix/staff school association dedupe #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sleblanc23
Copy link
Contributor

@sleblanc23 sleblanc23 commented Jan 29, 2025

Addresses a small issue with the deduplication rule for staff school associations. school_year is an optional field on the Ed-Fi resource, which has a primary key of staff - school- program assignment only. We construct school_year by coalescing this optional field with api_year and then include it in the dedupe, which will not remove duplicates that occur when the school_year field is updated.

This PR adds a second dedupe step, partitioning first with api_year to remove these update duplicates and then on school_year to remove duplicates across API years.

Tested in GSN; confirmed that it removed the duplicates.

@sleblanc23 sleblanc23 requested a review from rlittle08 January 29, 2025 16:16
@sleblanc23 sleblanc23 marked this pull request as draft January 30, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant