Bugfix/staff school association dedupe #118
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a small issue with the deduplication rule for staff school associations.
school_year
is an optional field on the Ed-Fi resource, which has a primary key ofstaff - school- program assignment
only. We constructschool_year
by coalescing this optional field withapi_year
and then include it in the dedupe, which will not remove duplicates that occur when theschool_year
field is updated.This PR adds a second dedupe step, partitioning first with
api_year
to remove these update duplicates and then onschool_year
to remove duplicates across API years.Tested in GSN; confirmed that it removed the duplicates.