feature/StudentAssessmentEducationOrg #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlittle08
reviewed
Oct 21, 2024
models/staging/edfi_3/stage/stg_ef3__student_assessment_education_organizations.sql
Outdated
Show resolved
Hide resolved
…s.sql to base_ef3__student_assessment_education_organization_associations.sql
….sql to stg_ef3__student_assessment_education_organization_associations.sql
* Update stg_ef3__grading_periods.sql * Update CHANGELOG.md * Update dbt_project.yml --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org>
…sociations after debugging
|
This looks great, but will need to hold for a minor version bump, bc it's a breaking change (implementations need to add the new raw table for this to compile). Alternatively, we could make the models disabled by default and release as a patch release, but no impetus for that yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this Monday item
This PR supports this feature by adding a new
baseandstgmodel for theStudentAssessmentEducationOrganizationsentity.PR Merge Priority:
New files:
base_ef3__student_assessment_education_organizations.sqlstg_ef3__student_assessment_education_organizations.sqlChanges to existing files:
gen_skey.sql: Updateskey_defswithStudentAssessmentreference_edfi_3__base.yml: Configure new base model_edfi_3__stage.yml: Configure new stg model + tests