This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Fix documentation - incorrect variable parameter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the documentation, issue found in edalzell#1
|
I appreciate this but I don't think this is right. to pass in a var you either need to do What's your use case where this didn't work as it is written? |
Updated the examples to show: - How to set the custom var based on a scope value - How to set a custom var based on a string value
|
Hi @edalzell, You're right I've misunderstood the documentation issue here. I've updated the patch with two examples:
The issue both myself and the creator of #1 had was that we were trying to set the value as a string, not from an existing scoped variable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the documentation, issue found in #1