Bug Fixes and Error Handling Improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Conditionally Show Wait Tooltip: - Moved the `ShowWaitTooltip()` call to occur only after successfully ensuring that text is selected. 2. Set System Cursor: - The line to set the system cursor to the wait state was moved to occur after checking if the text was successfully retrieved from the clipboard. 3. Error Handling in `PromptHandler`: - Wrapped the `GetTextFromClip()` call in a try-catch block within the `PromptHandler` function to handle cases where no text is selected. - If an error is caught (indicating no text is selected), `_running` is set to `false`, the cursor is restored, and the function returns early, preventing further processing or API calls. 4. Text Selection Logic: - Enhanced the text selection logic to check if text is already selected. If text is already selected, it doesn't re-select all text. - If no text is selected, it defaults to selecting all text. These changes ensure that the script only attempts to generate a response if text is selected, providing appropriate feedback to the user when no text is selected without proceeding to make unnecessary API calls.
The `SelectText()` function has been updated to ensure corrections are made only to selected text. If no text is selected, it will automatically select text based on the active application: - For Word/Outlook: selects the entire paragraph. - For Notepad++/VS Code: selects the entire line. - For other applications: selects all text. This ensures that the script respects existing text selections and only performs automatic selection when no text is selected.
Changes: 1. Bug Fix in `SelectText()` Function - Ensured clipboard is cleared before copying text to fix selection issues. 2. Input Length Validation in `CallAPI()` Function - Added check to prevent API requests if input length is less than 1 character. 3. Error Handling and Cursor Restoration in `CallAPI()` Function - Wrapped API request in a try-catch block. - Restored cursor and reset `_running` state before displaying error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Bug Fix in
SelectText()FunctionInput Length Validation in
CallAPI()FunctionError Handling and Cursor Restoration in
CallAPI()Function_runningstate before displaying error messages.