More Stuff #6
Merged
More Stuff #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to start refactoring/extracting helper methods soon
tidy up search for surrounding block in RenameInstanceVariable
Always replaces all instances irrespective of gdefault setting Add gsub_all_in_range() helper
Fix bug in RenameLocalVariable that could cause it to make ivars erroneously
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worth noting I've now changed Rename*Variable() methods significantly. They should be more resilient than before.
Also added a bunch of helper methods to:
No rush on merging it, hope you're enjoying the Windy City ;)
Cheers,