-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
支持使用组合定义模型 #99
支持使用组合定义模型 #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
设计用例设计得不错。可以帮忙重构一下这个测试用例吗?就是在三个地方都写一遍字段的元数据有点崩溃,改成大概这样的一个方法:
wantMeta: newTableMeta(tableName, columns)
columns 就是按照顺序放好的,然后内部把这个转成对应的两个 map,我觉得很能简化代码。
嘿嘿早期我这样测试,是因为早期我的元数据很简单,后面加多了之后我也没有改过来
收到~
收到~ |
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 81.61% 81.72% +0.11%
==========================================
Files 17 17
Lines 1077 1100 +23
==========================================
+ Hits 879 899 +20
- Misses 169 171 +2
- Partials 29 30 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@flyhigher139 接下来,你需要在构造 SQL 和执行查询的那些地方都加一些测试用例。按照道理来说,应该能够直接运行,毕竟我们只依赖于元数据。 然后你确认一下那个 parents 字段,在使用 index 之后我觉得那个可能用不上了 |
好的~ |
#70
完成组合,并添加了测试用例