Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/value: 抽象 Value 接口与基于反射的实现 #60

Merged
merged 1 commit into from
May 16, 2022

Conversation

flycash
Copy link
Contributor

@flycash flycash commented May 16, 2022

  • 将元数据抽象挪到 internal/model 包
  • 将方言抽象挪到 intenal/dialect 包
  • 抽象了 Value 接口并且提供了基于反射的实现

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #60 (19b5953) into main (1dc491e) will decrease coverage by 0.41%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   85.29%   84.87%   -0.42%     
==========================================
  Files          14       15       +1     
  Lines         809      833      +24     
==========================================
+ Hits          690      707      +17     
- Misses        101      107       +6     
- Partials       18       19       +1     
Impacted Files Coverage Δ
update.go 83.33% <84.61%> (ø)
builder.go 77.35% <87.50%> (ø)
internal/model/model.go 90.54% <93.10%> (ø)
select.go 89.94% <93.33%> (ø)
db.go 100.00% <100.00%> (ø)
delete.go 55.55% <100.00%> (ø)
insert.go 89.70% <100.00%> (ø)
internal/value/reflect/value.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc491e...19b5953. Read the comment docs.

@flycash flycash force-pushed the main branch 4 times, most recently from 876a8f3 to 6b62f9b Compare May 16, 2022 11:39
- 将元数据抽象挪到 internal/model 包
- 将方言抽象挪到 intenal/dialect 包
- 抽象了 Value 接口并且提供了基于反射的实现
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant