Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rft: remove defaultRegistry #46

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Rft: remove defaultRegistry #46

merged 1 commit into from
Oct 28, 2021

Conversation

flycash
Copy link
Contributor

@flycash flycash commented Oct 27, 2021

Users should make the decision that if use "global regitry". If they want, they should define their own global registry.

Users should make the decision that if use "global regitry". If they want, they should define their own global registry.
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #46 (2d407fd) into main (3373867) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   79.36%   79.61%   +0.24%     
==========================================
  Files          15       14       -1     
  Lines         727      721       -6     
==========================================
- Hits          577      574       -3     
+ Misses        133      129       -4     
- Partials       17       18       +1     
Impacted Files Coverage Δ
model.go 84.21% <ø> (-7.90%) ⬇️
db.go 84.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3373867...2d407fd. Read the comment docs.

@flycash flycash merged commit 665cf67 into ecodeclub:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant