-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata: default implementation of MetaRegistry #25
Conversation
model.go
Outdated
columnMetas = append(columnMetas, columnMeta) | ||
fieldMap[columnMeta.fieldName] = columnMeta | ||
} | ||
TableMeta := &TableMeta{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local variable should start with lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
model_test.go
Outdated
@@ -26,7 +27,7 @@ func TestTagMetaRegistry(t *testing.T) { | |||
if err != nil { | |||
t.Fatal(err) | |||
} | |||
assert.NotNil(t, err) | |||
assert.Nil(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already check the error, so we don't need to check it again
aff0591
to
7b85b08
Compare
7b85b08
to
23dc8ef
Compare
b71a4d8
to
2ef4648
Compare
model