metadata: default implementation of MetaRegistry #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flycash
reviewed
Sep 23, 2021
flycash
reviewed
Sep 24, 2021
model.go
Outdated
| columnMetas = append(columnMetas, columnMeta) | ||
| fieldMap[columnMeta.fieldName] = columnMeta | ||
| } | ||
| TableMeta := &TableMeta{ |
There was a problem hiding this comment.
local variable should start with lower case
model_test.go
Outdated
| @@ -26,7 +27,7 @@ func TestTagMetaRegistry(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| assert.NotNil(t, err) | |||
| assert.Nil(t, err) | |||
There was a problem hiding this comment.
we already check the error, so we don't need to check it again
xingjigongsi
force-pushed
the
dev-model-v5.1
branch
3 times, most recently
from
aff0591
to
7b85b08
Compare
flycash
approved these changes
Sep 24, 2021
xingjigongsi
force-pushed
the
dev-model-v5.1
branch
from
7b85b08
to
23dc8ef
Compare
xingjigongsi
force-pushed
the
dev-model-v5.1
branch
from
b71a4d8
to
2ef4648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model