-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
分库分表:聚合函数含groupby字句 #193
分库分表:聚合函数含groupby字句 #193
Conversation
//go:linkname convertAssign database/sql.convertAssign | ||
func convertAssign(dest, src any) error | ||
|
||
type GroupByColumn struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能不能在 merger 里面定义一个统一的 Column ? 我记得在很多地方都使用到了类似的结构。不过要是差异很大就没有必要抽取出来。
我主要是顾虑到,如果每一个实现都有类似的东西,但是都是各自定义一份,用户用起来是很困惑的,一会这个 Column,一会那个 Column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
又或者可以考虑放过去 aggregator 包?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以我把这两个抽到merger的type中你感觉还行不
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉可以
Codecov Report
@@ Coverage Diff @@
## dev #193 +/- ##
==========================================
- Coverage 86.16% 85.85% -0.31%
==========================================
Files 43 44 +1
Lines 3087 3274 +187
==========================================
+ Hits 2660 2811 +151
- Misses 345 372 +27
- Partials 82 91 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.