Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 分库分表: NOT 支持 #192

Merged
merged 7 commits into from
Apr 22, 2023
Merged

feature: 分库分表: NOT 支持 #192

merged 7 commits into from
Apr 22, 2023

Conversation

Stone-afk
Copy link
Collaborator

NOT 支持,部分集成测试待补充

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #192 (143e035) into dev (4deb1a0) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #192      +/-   ##
==========================================
+ Coverage   85.98%   86.16%   +0.18%     
==========================================
  Files          43       43              
  Lines        3046     3087      +41     
==========================================
+ Hits         2619     2660      +41     
  Misses        345      345              
  Partials       82       82              
Impacted Files Coverage Δ
predicate.go 92.00% <ø> (ø)
sharding_select.go 76.60% <100.00%> (+2.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的单测也没怎么覆盖啊!

sharding_select.go Outdated Show resolved Hide resolved
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一些代码依旧没有覆盖掉,你可以在 changed file 里面找到

sharding_select.go Outdated Show resolved Hide resolved
sharding_select.go Show resolved Hide resolved
sharding_select_test.go Show resolved Hide resolved
sharding_select.go Outdated Show resolved Hide resolved
internal/integration/sharding_select_test.go Show resolved Hide resolved
@flycash flycash merged commit c79a850 into ecodeclub:dev Apr 22, 2023
@flycash flycash linked an issue Apr 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

分库分表:NOT 支持
2 participants