Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: 调整主从的集成测试 #163

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

flycash
Copy link
Contributor

@flycash flycash commented Mar 2, 2023

  • 给 roundrobin 的 NewSlaves 增加了 error 返回值(以防万一)
  • 调整了部分局部变量命名
  • 引入了 testSlaves 来替代已有的双层结构

@codecov-commenter
Copy link

Codecov Report

Merging #163 (8634707) into dev (2b3a9b3) will increase coverage by 0.04%.
The diff coverage is 88.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #163      +/-   ##
==========================================
+ Coverage   79.64%   79.69%   +0.04%     
==========================================
  Files          29       30       +1     
  Lines        2334     2354      +20     
==========================================
+ Hits         1859     1876      +17     
- Misses        392      394       +2     
- Partials       83       84       +1     
Impacted Files Coverage Δ
master_slave_db.go 88.00% <ø> (ø)
internal/slaves/dns/dns.go 78.21% <66.66%> (-0.22%) ⬇️
internal/slaves/roundrobin/roundrobin.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants