Conversation
MSBANG
approved these changes
Jan 3, 2026
Contributor
MSBANG
left a comment
MSBANG
left a comment
There was a problem hiding this comment.
고생하셨습니다!
저는 머지하시면 추가하신 Controller, Service에 작업 하겠습니다!
kmindev
force-pushed
the
feature/admin-get-products
branch
from
6a96ea4 to
f4e57eb
Compare
- board와 boardStatistic(주인)이 1:1 관계에서 board(주인이 아닌쪽)에서 조회를 하면 LAZY 옵션 상관없이 boardStatistic 접근이 없음에도 N 번만큼 boardStatistic 조회쿼리가 발생한다. - EntityGraph를 통해 조인을 활용하여 boardStatistic를 즉시 로딩하도록 구현함
- test 코드에서 ddl 생성 시 문법 오류 발생하므로 삭제함.
- 수정에 따른 깨지는 테스트 추가 - 크롤링이면서 삭제되지 않은 데이터를 조회하는지 테스트 케이스 추가
- builder에서 isDeleted 필드가 빠졌기에 리플랙션을 통해 주입해주도록 변경
kmindev
force-pushed
the
feature/admin-get-products
branch
from
91a7f2b to
f2d56eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History
🚀 Major Changes & Explanations
board와boardStatistic(주인) 1:1 관계에서 board(주인이 아닌쪽)에서 조회를 하면 LAZY 옵션 상관없이boardStatistic접근이 없음에도 N 번만큼boardStatistic조회쿼리가 발생하는 문제가 있었습니다.@EntityGraph를 통해 조인을 활용하여 boardStatistic를 즉시 로딩하도록 구현하여 문제를 해결했습니다.product_board테이블에is_crawling컬럼 추가 (erd 클라우드 업데이트 완료)