-
Notifications
You must be signed in to change notification settings - Fork 18
Call GRIB2 encoder in metkit #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tweska
wants to merge
9
commits into
develop
Choose a base branch
from
feature/metkit-grib2-encoder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+164
β390,988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a584f4 to
86ae89d
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
- Coverage 57.88% 55.96% -1.93%
===========================================
Files 319 324 +5
Lines 20533 21238 +705
Branches 1595 1675 +80
===========================================
- Hits 11886 11885 -1
- Misses 8647 9353 +706 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
55e527e to
e093e4f
Compare
f92a7be to
88faf30
Compare
Member
Author
|
Just a note: We must remove the commits that change the CI before we merge! |
439d213 to
3e0ac92
Compare
3e0ac92 to
ee3afcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must stay as a draft until the required changes are merged in metkit (ecmwf/metkit#143).
ππ¦οΈππ§ Documentation π§ππ¦οΈπ
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-228