Skip to content

Generalize param mapping and allow setting arbitrary metadata in statistics-mtg2 action #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: feature/statistics-mtg2
Choose a base branch
from

Conversation

tweska
Copy link
Member

@tweska tweska commented May 7, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/statistics-mtg2@29c0fc5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...o/action/statistics-mtg2/StatisticsParamMapping.cc 0.00% 30 Missing ⚠️
...io/action/statistics-mtg2/cfg/StatisticsOptions.cc 0.00% 14 Missing ⚠️
src/multio/action/statistics-mtg2/Statistics.cc 0.00% 8 Missing ⚠️
...io/action/statistics-mtg2/StatisticsParamMapping.h 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/statistics-mtg2     #104   +/-   ##
==========================================================
  Coverage                           ?   46.90%           
==========================================================
  Files                              ?      260           
  Lines                              ?    17395           
  Branches                           ?     1423           
==========================================================
  Hits                               ?     8159           
  Misses                             ?     9236           
  Partials                           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tweska tweska changed the title Generalized param mapping for statistics-mtg2 through central mapping file Generalized param mapping and allow setting arbitrary metadata in statistics-mtg2 action May 8, 2025
@tweska tweska changed the title Generalized param mapping and allow setting arbitrary metadata in statistics-mtg2 action Generalize param mapping and allow setting arbitrary metadata in statistics-mtg2 action May 8, 2025
Copy link
Collaborator

@dsarmany dsarmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Let's start with addressing those and then we can have another go.

}
}

StatisticsParamMapping* StatisticsParamMapping::instance() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't create a singleton for this just yet. We may do that later, if need be. Also, there is very specific pattern to follow when we do create a singleton. See Aggregation or Mask, for example.

@tweska tweska force-pushed the feature/statistics-mtg2-mapping branch from d47ef57 to c90105c Compare May 9, 2025 12:11
@tweska tweska requested a review from dsarmany May 9, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants