Skip to content

Use serialisation alias in dumping of plans #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Jan 21, 2025

Fix plans not using the alias.

@HCookie HCookie added the bug Something isn't working label Jan 21, 2025
@HCookie HCookie requested a review from pgeier January 21, 2025 14:14
@HCookie HCookie self-assigned this Jan 21, 2025
Copy link
Contributor

@pgeier pgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

Now we have to fix follow up problems in multio... :)

@pgeier pgeier self-requested a review January 21, 2025 14:21
pgeier
pgeier previously approved these changes Jan 21, 2025
@HCookie HCookie changed the base branch from main to develop January 21, 2025 14:38
@HCookie HCookie dismissed pgeier’s stale review January 21, 2025 14:38

The base branch was changed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.73%. Comparing base (1a817ed) to head (194e544).

Files with missing lines Patch % Lines
multio/plans/plans.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop       #9   +/-   ##
========================================
  Coverage    31.73%   31.73%           
========================================
  Files           15       15           
  Lines          709      709           
========================================
  Hits           225      225           
  Misses         484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pgeier pgeier merged commit dca3d21 into develop Jan 21, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants