Feature/eckit 653 metrics list #247
Open
+601
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
===========================================
+ Coverage 65.86% 66.24% +0.38%
===========================================
Files 1129 1131 +2
Lines 57671 57960 +289
Branches 4365 4395 +30
===========================================
+ Hits 37985 38397 +412
+ Misses 19686 19563 -123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ozaq
requested changes
Jan 23, 2026
Member
Ozaq
left a comment
Ozaq
left a comment
There was a problem hiding this comment.
Some minor change request. Please provide some documentation.
tests/runtime/test_metrics.cc
Outdated
Comment on lines
159
to
165
| { | ||
| eckit::MetricsGroup grp("group"); | ||
| Metrics::set("int", 1); | ||
| eckit::MetricsGroupItem gi; | ||
| Metrics::set("int", 2); | ||
| } | ||
| expect(",\"group\":[{\"int\":1},{\"int\":2}]}", metrics); |
Member
There was a problem hiding this comment.
Looking at this; Does this mean a group contains an implicit GroupItem?
Comment on lines
90
to
102
| class MetricsGroup { | ||
| public: | ||
|
|
||
| MetricsGroup(const std::string& prefix); | ||
| ~MetricsGroup(); | ||
| }; | ||
|
|
||
| class MetricsGroupItem { | ||
| public: | ||
|
|
||
| MetricsGroupItem(); | ||
| ~MetricsGroupItem(); | ||
| }; |
Member
There was a problem hiding this comment.
Can you add a bit of documentation to this? Its not immediately clear how this is supposed to work
…mwf/eckit into feature/ECKIT-653-metricsList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add the ability to create groups of metrics
(requested in mars-server to list all the files in which a big layout is subdivided)
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-247