Switch eccodes python to wheelchains #114
Open
+317
−412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmi
force-pushed
the
project/wheelify
branch
2 times, most recently
from
d2448fa to
815ccaf
Compare
tmi
force-pushed
the
project/wheelify
branch
11 times, most recently
from
e32d2c9 to
ef5b847
Compare
tmi
force-pushed
the
project/wheelify
branch
3 times, most recently
from
b5373ff to
7d9973a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #114 +/- ##
===========================================
- Coverage 33.15% 32.74% -0.41%
===========================================
Files 16 17 +1
Lines 2645 2678 +33
Branches 190 194 +4
===========================================
Hits 877 877
- Misses 1752 1785 +33
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the
eccodespython package to rely on wheelchain -- in particular, the wheel produced in ecmwf/eccodes#277The changes are in short:
1/ switching the wheel build to be done in a docker with common tooling present
2/ pulling the wheel with binary eccodes at buildtime and using it for lib/include
3/ updating the
findlibscall at runtime to find the right.soWhat is (currently) missing:
1/ add a dep lowerbound to findlibs (ecmwf/findlibs#14 -- not released yet)
2/ switch from test pypi to real one (nothing published yet)
3/ add in full matrix over python versions, platforms, etc