feat: rolling average on read #426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-hopkinson
requested changes
Sep 30, 2025
Contributor
aaron-hopkinson
left a comment
aaron-hopkinson
left a comment
There was a problem hiding this comment.
Could probably also do with some documentation and tests given that it's a new feature
github-project-automation
bot
moved this from To be triaged
to Under Review
in Anemoi-dev
Co-authored-by: Aaron Hopkinson <197336788+aaron-hopkinson@users.noreply.github.com>
Co-authored-by: Aaron Hopkinson <197336788+aaron-hopkinson@users.noreply.github.com>
jakob-schloer
approved these changes
Oct 8, 2025
jakob-schloer
left a comment
jakob-schloer
left a comment
There was a problem hiding this comment.
Great work! Everything works very nicely now!
I've tested with several combinations of single, joined and concatenated datasets:
- Length
- Shape
- Correct dates
- Averaging across time
- Combining datasets that are averaged and those that are not
Member
Author
|
replaced by #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.