Skip to content

Conversation

b8raoult
Copy link
Collaborator

@b8raoult b8raoult commented May 10, 2025

Description

Support for aliases in xarray metadata, e.g. levelist => level

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@github-actions github-actions bot added the bug Something isn't working label May 10, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev May 23, 2025
Copy link
Contributor

@aaron-hopkinson aaron-hopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to the best of my knowledge.

Is it worth adding tests to capture the new behaviour? (adding metadata aliases)

@aaron-hopkinson
Copy link
Contributor

Merged in main and resolved conflicts

@aaron-hopkinson aaron-hopkinson merged commit 4304cb4 into main Aug 4, 2025
69 checks passed
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev Aug 4, 2025
@aaron-hopkinson aaron-hopkinson deleted the fix/better-handling-of-xarray-metadata branch August 4, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants