fix: bug in variables ordering in NormalizedReluBounding #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzampier
changed the title
sahahner
reviewed
Jan 28, 2025
|
Would it make sense to add a test that would catch this bug next time? |
|
The effect of the bug does only show in the training metrics. I can write a test that fails if the order of variables is still wrong after the initialization. |
Yes, more tests would be good. I would postpone this to a different pull request, given that we will refactor the interface of this function to make it simpler over the next days. The tests will also inevitably change for the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug affects
anemoi.models.layers.bounding.NormalizedReluBoundingif the order of the variable douring the call in config does not match the order of the variables in the torch array. This a problem emerged only when multiple variables were bounded at the same time with this procedure.This is fixed by making sure that
self.norm_min_valfollows the same order asself.data_index.