-
Notifications
You must be signed in to change notification settings - Fork 49
Clessig/develop/fix config 1534 #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…training_config and validation_config
…culator and various other details cleaned up
…of config is passed to LRScheduler, which leads to major simplifications
|
forecast, ERA5 + NPP-ATMS + SYNOP num_samples/batch_size = 1: (520709 : g479xfk6) 0: LossPhysical.ERA5.mse.avg : 9.4735E-02 num_samples/batch_size = 2: 520711 : ypix0nr7 0: LossPhysical.ERA5.mse.avg : 1.1328E-01 |
Description
Revise config to nested dict; simplify code where possible and where changes are necessary anyway.
This PR also enables a more flexible combination of different loss terms, e.g. of a physical space and latent loss, as demonstrated in the default config. It also decouples training and validation and test as much as possible, so that one can have different objectives for these.
Issue Number
Closes #1534
Closes #1535
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60