Skip to content

Conversation

@iluise
Copy link
Collaborator

@iluise iluise commented Dec 19, 2025

Description

The way one needs to input the quaver templates in export is a bit confusing at the moment. with this PR the user will just input the template folder and the grid type and the template format is created under the hood.

Issue Number

Closes #1286

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@iluise iluise self-assigned this Dec 19, 2025
@iluise iluise added the eval anything related to the model evaluation pipeline label Dec 19, 2025
@iluise iluise merged commit 468ab07 into develop Dec 19, 2025
5 checks passed
TillHae pushed a commit to TillHae/WeatherGenerator that referenced this pull request Dec 25, 2025
* add default template

* update instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add defaults for the --template flag in export package

3 participants