Skip to content

Conversation

@shmh40
Copy link
Contributor

@shmh40 shmh40 commented Dec 19, 2025

passing thru local assimilation

Description

Bug in encoder in assimilate_local. For very sparse masks and hence tokens, sometimes the chunking logic in assimilate_local will lead to empty tokens_c since there are no tokens in the "chunk" of the tokens that we inspect.

Issue Number

Closes #1494

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@shmh40 shmh40 requested a review from clessig December 19, 2025 10:33
@shmh40 shmh40 self-assigned this Dec 19, 2025
@shmh40 shmh40 added the bug Something isn't working label Dec 19, 2025
@shmh40 shmh40 merged commit 9d38503 into develop Dec 19, 2025
5 checks passed
TillHae pushed a commit to TillHae/WeatherGenerator that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

tokens_c chunking breaking local assimilation for sparse masks

3 participants