WeatherGenerator JSON reader #1461
Draft
+169
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluise
reviewed
Jan 6, 2026
Collaborator
iluise
left a comment
iluise
left a comment
There was a problem hiding this comment.
I went through the code and I like the implementation. I will test it after it is updated to develop.
p.s. do you have ideas on how we could split the weathergen_reader in multiple files? it is getting quite long and it might be useful to slice it into more files
|
|
||
| for run_id, run in runs.items(): | ||
| reader = WeatherGenReader(run, run_id, private_paths) | ||
| reader = WeatherGenZarrReader(run, run_id, private_paths) |
Collaborator
There was a problem hiding this comment.
we should test that this does not crash with mlflow or skip the runs that do not use zarrReaders
| stream=list(self.eval_cfg.streams.keys())[0] | ||
| region=actual_eval_cfg.regions[0] | ||
| metric=actual_eval_cfg.metrics[0] | ||
| dummy = self.load_scores( stream, region, metric ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the option to read only the stored WeatherGen scores from JSON in the evaluation package, as requested in Issue #1202. To avoid duplication of code, the previous WeatherGenReader is split into a zarr reader and a json reader, which maybe wasn't the best idea.