Skip to content

Conversation

@wael-mika
Copy link
Contributor

Description

Implementing the temporal cropping based on the updates to the masking's new structure

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@wael-mika wael-mika marked this pull request as ready for review December 4, 2025 11:00
@tjhunter tjhunter changed the title Implementing the temporal cropping after rebasing [mask] Implementing the temporal cropping after rebasing Dec 30, 2025
@clessig
Copy link
Collaborator

clessig commented Jan 5, 2026

Outdated and partially merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants