Skip to content

Conversation

@clessig
Copy link
Collaborator

@clessig clessig commented Nov 12, 2025

Description

NOT WORKING: initial draft for index-based masking. Implemented for random and healpix masking. Open issues with _coords_local, centroids and probably other things.

Issue Number

Closes #1242

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

…andom and healpix masking. Open issues with _coords_local, centroids and probably other things.
@github-actions github-actions bot added the model Related to model training or definition (not generic infra) label Nov 12, 2025
@shmh40 shmh40 self-requested a review November 12, 2025 08:54
@clessig clessig moved this to In Progress in WeatherGen-dev Nov 14, 2025
@clessig
Copy link
Collaborator Author

clessig commented Nov 18, 2025

Superseeded by #1283

@clessig clessig closed this Nov 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in WeatherGen-dev Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Related to model training or definition (not generic infra)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Convert masking to be index based

2 participants