Linter: Internalize functionality and scheduler integration stub #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/44 |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 91.07% 91.65% +0.57%
==========================================
Files 86 86
Lines 15043 15206 +163
==========================================
+ Hits 13701 13937 +236
+ Misses 1342 1269 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I believe this is ready for a look. |
reuterbal
force-pushed
the
nabr-linter-via-scheduler
branch
from
4f056f9
to
250ba62
Compare
Merged
reuterbal
force-pushed
the
nabr-linter-via-scheduler
branch
from
6cd92b4
to
2f328e5
Compare
mlange05
approved these changes
Mar 31, 2023
| nx.DiGraph | ||
| """ | ||
| paths = {item.path for item in self.item_graph} | ||
| basepath = Path(commonpath([str(p) for p in paths])) |
There was a problem hiding this comment.
[no action] Neat. Might need to use this approach in Scheduler in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: filing this early for test coverage and while testing offline.
This PR moves some of the functionality from
loki-lint.pyinto theloki.lintmodule to facilitate testing. In that process, some of the functionality could be replaced by internal utility functions. With this, we now have a new entry point for linting:lint_filesThis PR also bundles a first stub of a scheduler integration for the linter. It implements linting as a transformation that is applied across the scheduler's graph.
However, since linting is file based, this required equipping the Scheduler with a file-centric view of dependencies. For that purpose, the scheduler has been equipped with the ability to generate a file graph for the scheduler's item_graph, and optionally use that in
process. This may be handy for the FileWriteTransformation, too.The CLI script for checking in loki-lint.py is now only responsible for reading the YAML config and filling the config dict.