Skip to content

Conversation

@daniel-shuy
Copy link
Contributor

@daniel-shuy daniel-shuy commented Jan 21, 2026

When translating oneOf, pass the subschema to the Translator to be consistent with other Translator calls so that the Translator can access the subschema, e.g.

const specializedErrorMessage = t(customErrorKey, undefined, {
schema,
uischema,
path,
errors,
});

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 6832da7
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/6981719fc46e4a0008d04bef
😎 Deploy Preview https://deploy-preview-2536--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2026

CLA assistant check
All committers have signed the CLA.

@lucas-koehler lucas-koehler self-requested a review January 30, 2026 14:58
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daniel-shuy, thanks for the contribution ❤️ This definitely makes sense to me. I have one comment inline regarding consistency with existing passing of schemas to the translator. Please have a look :)

@lucas-koehler lucas-koehler added this to the 3.x milestone Jan 30, 2026
@daniel-shuy daniel-shuy force-pushed the feat/pass-oneof-subschema-to-translator branch from 682664b to 6832da7 Compare February 3, 2026 03:55
@coveralls
Copy link

Coverage Status

coverage: 82.798%. remained the same
when pulling 6832da7 on daniel-shuy:feat/pass-oneof-subschema-to-translator
into d1d2c86 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and the contribution. LGTM now 🚀

@lucas-koehler lucas-koehler merged commit 563015d into eclipsesource:master Feb 3, 2026
8 checks passed
@daniel-shuy daniel-shuy deleted the feat/pass-oneof-subschema-to-translator branch February 3, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants