Skip to content

Enable ESLint no-prototype-builtins rule and fix errors #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023

Conversation

lucas-koehler
Copy link
Contributor

Use Object.prototype.<method>.call(<object>, <property>) syntax instead of directly calling the methods on the objects. This is the suggested fix in the rule documentation.

Part of #2131

Use Object.prototype.<method>.call(<object>, <property>) syntax
instead of directly calling the methods on the objects.
This is the suggested fix in the rule documentation.

Part of #2131
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 671bce6
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6453d9d51ede1c0008677b7b
😎 Deploy Preview https://deploy-preview-2134--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lucas-koehler lucas-koehler mentioned this pull request May 4, 2023
5 tasks
@coveralls
Copy link

Coverage Status

Coverage: 84.254%. Remained the same when pulling 671bce6 on 2131-no-protoype-builtins into f8ea38f on master.

@lucas-koehler lucas-koehler requested a review from sdirix May 4, 2023 16:41
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit b11f04c into master May 12, 2023
@sdirix sdirix deleted the 2131-no-protoype-builtins branch May 12, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants